Step 2 - Convert SelectUsers component #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we needed to find a way to optimize our
expensiveCalculationOnUsers
so that it didn't run every time the component rendered, but it did update when theusers
prop changed.The first and most simple way to do that is by using
useMemo
:However, we can't produce side effects inside of the
useMemo
function. So, ifexpensiveCalculationOnUsers
relied on afetch
for instance, we would need to turn touseEffect
once again.The version of
SelectUsers
that is in this branch reflects this reality: we combineuseState
anduseEffect
to manage our expensive calculation, and by addingusers
to theuseEffect
dependency array, ensure that our component is always synced with theusers
prop.